Article 23
Forgot to cherry-pick them from the previous iteration. Changes pushed to branch:t/13142c.
View Articlestatus changed
status changed from assigned to review I merged together the parts that deal with <p> on IE and <div> on Edge. Changes pushed to branch:t/13142c.
View Articlestatus changed
status changed from assigned to review I solved the problem with overlapping events by locking marking and removing appropriately. Tests added that show how this mechanism behaves. Changes pushed to...
View ArticleArticle 17
While I was fixing the problem with the infinite loop I found an edge case that we need to cover: if the user, instead of pressing backspace, starts typing the selectionchange event fires when the...
View ArticleArticle 16
Fixed that infinite loop, but there's another problem that I found: selecting all and pressing any alphanumeric key bypasses the implemented protection on Edge. I'll fix this and add an appropriate...
View Articlestatus changed
status changed from review to review_failed After your change there is circular reference and browser crash when I press CTRL+A;Backspace. See that you only check that the enter mode is different than...
View ArticleArticle 13
As always there was more to this than a single line of code that needed to be changed. I added unit tests that create this situation regardless of the browser they are run on. Changes pushed to...
View ArticleArticle 12
I found the piece of code that deletes that <p> in IE11 in enterMode=ENTER_DIV: https://github.com/cksource/ckeditor-dev/blob/t/13142a/plugins/wysiwygarea/plugin.js#L176 I'll modify it so that...
View ArticleArticle 11
And one more think: debugging and, in general, working with tickets on Edge, is very hard now, because Edge is too unstable. I believe handling are reviewing tickets like this at this stage is a waste...
View Articlestatus changed
status changed from review to review_failed First of all note that this problem occurred only using Backspace. Then I use Delete additional <div> is not added. I checked the behavior on other...
View Articlestatus changed
status changed from assigned to review Changes pushed to branch:t/13142a. I had to put deleting the div after adding the bogus, because node removal invalidates the selection.
View ArticleArticle 8
Here is the sequence of events that leads to this bug: When the user hits backspace (or delete) on the whole selected content then it gets deleted and the browser inserts an empty, superfluous...
View ArticleArticle 7
I guess we should create at least a temporary fix. We'll have to watch out for regressions in case the Edge devs change something again to make this behavior consistent in their browser(that is if...
View ArticleArticle 6
Ok, thanks. But as you can see - none of the browsers give the expected result which is <p><br></p>. We fix this somehow. Question is - why we don't fix it on Edge?
View ArticleArticle 5
Other browsers that I tested have the following behavior: IE11 @ Win10: Empty <p> Chrome @ Ubuntu: Single <br> What's important is that if it's not the <body> element that's editable...
View ArticleArticle 4
How does IE11 and other browsers handle CTRL+A;DEL natively? It isn't so obvious that this is a bug unfortunately. Also, we may be already manually handling CTRL+A;DEL on some browsers. This should be...
View Article